Skip to content

Regression: Add scope to permission checks in Team's endpoints #21369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 9 commits into from
Mar 31, 2021
Merged

Regression: Add scope to permission checks in Team's endpoints #21369

sampaiodiego merged 9 commits into from
Mar 31, 2021

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Mar 30, 2021

Proposed changes (including videos or screenshots)

  • Include scope (team's main room ID) in the permission checks;
  • Remove the teamName parameter from the members, addMembers, updateMember and removeMembers methods (since teamId will always be defined).

Issue(s)

Task - ClickUp

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego merged commit 03144c4 into develop Mar 31, 2021
@sampaiodiego sampaiodiego deleted the teams-scope-permissions branch March 31, 2021 21:09
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matheusbsilva137 @sampaiodiego